Bugfix/3099/fix crash when open ai translation is enabled #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
bugfix/3099/fixCrashWhenOpenAiTranslationIsEnabled
branch
from
e469eb2
to
7b39ea8
Compare
mahibi
force-pushed
the
bugfix/3099/fixCrashWhenOpenAiTranslationIsEnabled
branch
from
a8543d9
to
05e467a
Compare
mahibi
added
3. to review
mahibi
force-pushed
the
bugfix/3099/fixCrashWhenOpenAiTranslationIsEnabled
branch
2 times, most recently
from
28eb895
to
1ac35eb
Compare
rapterjet2004
approved these changes
Jun 30, 2023
sending too much data via intent always is a bad pattern which can lead to TransactionTooLargeException. When OpenAI translation is enabled, the capabilities contain a ton of translation combinations. These capabilities are contained in 'currentUser' as well in 'selectedConversation'. So, TransactionTooLargeException was thrown. this PR: - avoids passing too much data as parcelables in intents (esp. conversation and user) - introduces MVVM patterns to load required data (esp conversation) from backend (for now via requests, in the future from database first) - introduces ConversationModel which is created out of the Conversation json model - loads user data via injection when possible - creates some quickfixes in ConversationBottomDialog, EntryMenuController and OperationsMenuController. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
The parsed result was without quotes which resulted in error:
Unterminated object at character 21 of [{fromLabel=English (US),
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
bugfix/3099/fixCrashWhenOpenAiTranslationIsEnabled
branch
from
1ac35eb
to
cbf74cc
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3122-talk.apk |
delete-merged-branch
bot
deleted the
bugfix/3099/fixCrashWhenOpenAiTranslationIsEnabled
branch
|
/backport to stable-17.0 |
|
The backport to stable-17.0 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-17.0
git pull origin stable-17.0
# Create the new backport branch
git checkout -b fix/foo-stable-17.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-17.0More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
expected.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3099
Bug was caused by sending too much data via intent (leads to crash / TransactionTooLargeException).
When OpenAI translation is enabled, the capabilities contain a ton of translation combinations. These capabilities are contained in 'currentUser' as well in 'selectedConversation'. So, TransactionTooLargeException was thrown.
this PR:
馃毀 TODO for Follow up PR's
Simplify ConversationBottomDialog, EntryMenuController and OperationsMenuController.
These classes need some refactoring anyway to remove conductor.
Avoid using the Conversation JSON model throughout the app. Replace with new ConversationModel.
Further move code to ViewModels
Create new models from JSON, e.g. for chat message etc.. Include "lastMessage" in ConversationModel
Remove methods from Conversation JSON model. use ConversationUtil instead that uses the domain model.
馃弫 Checklist
/backport to stable-xx.x