Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open internal links for files app from any screen + open talk links inside the app #3923

Merged
merged 2 commits into from
May 24, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented May 21, 2024

Followup improvements to #3922

With this change, all links that target files in the same nextcloud instance will be opened in the files app, no matter on which screen the link was (e.g. useful when links are posted in conversation descriptions...).

  • enhance this to also handle talk links inside the app itself

How to test

  • share some files url to chat & open
  • share some talk url to chat & open

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this May 21, 2024
@mahibi mahibi added this to the 19.1.0 milestone May 21, 2024
@mahibi mahibi marked this pull request as draft May 22, 2024 13:22
@mahibi mahibi force-pushed the bugfix/noid/openFilesAppFromAnyActivity branch from 900670e to c0378c4 Compare May 23, 2024 13:55
@mahibi mahibi changed the title open links for files app from any screen. open links for files app from any screen + open talk links inside the app May 23, 2024
@mahibi mahibi marked this pull request as ready for review May 23, 2024 13:57
@mahibi mahibi added the 3. to review Waiting for reviews label May 23, 2024
@sowjanyakch
Copy link
Contributor

I shared a file URL to chat and opened the link. It redirects to the browser instead of the files app. Talk links work as expected.

@mahibi
Copy link
Collaborator Author

mahibi commented May 24, 2024

I shared a file URL to chat and opened the link. It redirects to the browser instead of the files app. Talk links work as expected.

currently only internal links with /f/ are supported.

the link that @sowjanyakch used was a public link with /s/
Like https://server.com/s/RdT8pPLj4SNq5qS

I'm not sure whats the best way to handle public links, but it won't be done with this PR

@mahibi mahibi changed the title open links for files app from any screen + open talk links inside the app open internal links for files app from any screen + open talk links inside the app May 24, 2024
With this change, all links that target files in the same nextcloud instance will be opened in the files app, no matter on which screen the link was.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/noid/openFilesAppFromAnyActivity branch from 08ff6ea to 932352b Compare May 24, 2024 13:39
@mahibi mahibi enabled auto-merge May 24, 2024 13:43
Copy link

Codacy

Lint

TypemasterPR
Warnings8181
Errors119119

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code8484
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total114114

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3923-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 2995aa8 into master May 24, 2024
18 checks passed
@mahibi mahibi deleted the bugfix/noid/openFilesAppFromAnyActivity branch May 24, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants