Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-19.0] Bugfix/3669/fix to open preview links in files app #3934

Merged
merged 2 commits into from
May 22, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 22, 2024

Backport of PR #3922

only links without index.php returned true without this fix.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
The wrong context was passed, so the overwritten startActivity in ChatActivity was not called.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@backportbot backportbot bot added the 3. to review Waiting for reviews label May 22, 2024
@backportbot backportbot bot added this to the 19.0.1 milestone May 22, 2024
Copy link

Codacy

Lint

TypemasterPR
Warnings8181
Errors11910

SpotBugs

CategoryBaseNew
Bad practice66
Correctness118
Dodgy code8488
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total114115

SpotBugs increased!

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3934-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit d33ce0b into stable-19.0 May 22, 2024
15 of 16 checks passed
@mahibi mahibi deleted the backport/3922/stable-19.0 branch May 22, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant