Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to kotlin 2.0 / use ksp where possible #3970

Merged
merged 1 commit into from
Jun 18, 2024
Merged

update to kotlin 2.0 / use ksp where possible #3970

merged 1 commit into from
Jun 18, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jun 17, 2024

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
update to kotlin 2.0 / use ksp where possible
00101ab 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added the 3. to review Waiting for reviews label Jun 17, 2024
@mahibi mahibi added this to the 19.1.0 milestone Jun 17, 2024
@mahibi mahibi self-assigned this Jun 17, 2024
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7979
Errors10129

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code8484
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total114114

Lint increased!

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3970-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 1e14532 into master Jun 18, 2024
18 of 19 checks passed
@mahibi mahibi deleted the kotlin2.0 branch June 18, 2024 07:23
@mahibi mahibi mentioned this pull request Jun 18, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
19.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mahibi @AndyScherzinger