fix(patchers): fix patching modules resolving by require.resolve #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative solution to fix problems mentioned in #239
Previously for patched modules in patching it uses absolute paths to the original modules like
It breaks if the absolute path is changed inside the module. Mentiond PR fixes the problem for
spreed@stable27+
but breaks forspreed@stable26
. Because of the absolute path, it may happen with any module at any time.New solution resolves a real path by
require.resolve
and provides it by new aliases, for exampleAlso, moved the patchers so their path looks like a path to the corresponding npm module.
Thanks @Antreesy for finding and explaining the problem 馃挋