Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(talk): support Pinia talkHashStore for Talk 19 #542

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix(talk): support Pinia talkHashStore for Talk 19 #542

merged 1 commit into from
Mar 1, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Feb 28, 2024

☑️ Resolves

Since Nextcloud 29 (Talk 19)

How to test:

  1. Open Talk Desktop
  2. Change admin settings
  3. In 30 seconds Talk Desktop should restart
  4. Should work on main / stable27 / stable28

🚧 Tasks

  • Add Talk Hash Store adapters for Vuex and Pinia
  • Check if the Pinia store exists and use Vuex as a fallback
  • Work with Talk Hash via adapter

@ShGKme ShGKme added bug Something isn't working 3. to review labels Feb 28, 2024
@ShGKme ShGKme self-assigned this Feb 28, 2024
DorraJaouad
DorraJaouad approved these changes Feb 29, 2024
View reviewed changes
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/talk/renderer/init.js Outdated Show resolved Hide resolved
@ShGKme
fix(talk): support Pinia talkHashStore
7b8dcd6 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Antreesy
Antreesy approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reload on dirty hash works

@ShGKme ShGKme merged commit 1652394 into main Mar 1, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/talk-hash-with-pinia branch March 1, 2024 10:27
@ShGKme ShGKme mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShGKme @DorraJaouad @Antreesy