Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(screensharing): better sort and name available sources #618

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 17, 2024

☑️ Resolves

Yesterday during the call, I suddenly selected "Entire screen with audio" option, so other attendants heard themselves. This is not the options I wanted to choose, just mixed-up. And that's me who developed the feature 🙈

🚧 Tasks

  • Make a name for the entire screen with audio shorter, and with Audio in the beginning
  • Change the icon to just audio instead of screen with a speaker
  • Put this option after the screen, not as the first option
  • Manually sort sources to always have screens before windows

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Also, sometimes it was randomly in this order before:

image

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review design labels Apr 17, 2024
@ShGKme ShGKme self-assigned this Apr 17, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested with two screens

@ShGKme ShGKme merged commit 5438f4b into main Apr 17, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/screen-sharing-entire-desktop-option branch April 17, 2024 11:22
@ShGKme ShGKme mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants