fix: show mime type icon for attachments in messages #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
changed the title
|
Most of them but not all of them. |
Antreesy
approved these changes
Apr 18, 2024
src/shared/globals/globals.js
Outdated
| @@ -24,6 +24,7 @@ import { translate, translatePlural } from '@nextcloud/l10n' | |||
|
|
|||
| import { appData } from '../../app/AppData.js' | |||
| import { dialogs } from './OC/dialogs.js' | |||
| import { MimeTypeList } from './OC/MimeType.js' | |||
There was a problem hiding this comment.
incorrect filename, build is failing
There was a problem hiding this comment.
I though eslint-pluing-import should have caught this 🙈
DorraJaouad
approved these changes
Apr 18, 2024
See https://github.com/nextcloud/talk-android/blob/f5a4274e545f506861dc7baf7f92ec5e73d674f6/app/src/main/java/com/nextcloud/talk/utils/DrawableUtils.kt for android, did not compare.. |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/oc-MimeType-getIconUrl
branch
from
1b26b28
to
4e14804
Compare
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Might not be the best solution, but as a workaround.
@Ivansss @mahibi Do you use all available icons for mime types from server, including theming?
🖼️ Screenshots