Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: workaround for multi-account support with several instance with different executable names #620

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat: workaround for multi-account support with several instance with different executable names #620

merged 1 commit into from
Apr 18, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 17, 2024 •
edited

☑️ Resolves

  • Multi-account support is covered by Add multi-accounts support #7
  • But full multi-account support is not a simple feature...
  • As a temporal workaround allow renaming executable to have several simultaneously running Talk Desktop instances
  • Also useful for testing federations
/path/to/apps/
├── home-apps/
│   └── Nextcloud Talk/
│       ├── ...
│       ├── Nextcloud Talk (Home).exe
│       └── ...
└── work-apps/
    └── Nextcloud Talk/
        ├── ...
        ├── Nextcloud Talk (Work).exe
        └── ...

🖼️ Screenshots

image

@ShGKme ShGKme added enhancement New feature or request 3. to review labels Apr 17, 2024
@ShGKme ShGKme self-assigned this Apr 17, 2024
marcoambrosini
marcoambrosini approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@ShGKme ShGKme force-pushed the feat/workaround-for-multi-account branch from a60d0b5 to f008606 Compare April 17, 2024 15:06
@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 17, 2024 •
edited

Pushed: now the app is using the app name in the title

@ShGKme ShGKme force-pushed the feat/workaround-for-multi-account branch from f008606 to e634f59 Compare April 17, 2024 15:08
@ShGKme
feat: workaround for multi account support via separated instances
7bcc5d8 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the feat/workaround-for-multi-account branch from e634f59 to 7bcc5d8 Compare April 18, 2024 14:46
@ShGKme ShGKme merged commit b38c82b into main Apr 18, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/workaround-for-multi-account branch April 18, 2024 14:56
@ShGKme ShGKme mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShGKme @marcoambrosini