Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枛 Breakout rooms #1060

Merged
merged 11 commits into from Feb 2, 2023
Merged

馃枛 Breakout rooms #1060

merged 11 commits into from Feb 2, 2023

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Jan 31, 2023

Fix #981

@SystemKeeper
Copy link
Collaborator

Some comments:

  • Switching is working very smoothly - I like it!
  • I had a crash when switching:
    Assertion failed: (_internal->figCaptureSession == NULL), function -[AVCaptureVideoPreviewLayer attachToFigCaptureSession:]_block_invoke, file AVCaptureVideoPreviewLayer.m, line 1201.
    dyld4 config: DYLD_LIBRARY_PATH=/usr/lib/system/introspection DYLD_INSERT_LIBRARIES=/Developer/usr/lib/libBacktraceRecording.dylib:/Developer/usr/lib/libMainThreadChecker.dylib:/Developer/Library/PrivateFrameworks/DTDDISupport.framework/libViewDebuggerSupport.dylib
    
    This only happened once and I was not able to reproduce it again.
  • When switching the old session is not ended? I switched between Room1 and Room2. So initially I joined in Room1 and then switched to Room2, but my last frame was still visible in Room1 and the status on the cell changed to "Failed to connect to...". Sometimes I wasn't able to establish a connection again after that, but that might be a problem of my test env.
  • Sometimes the chat is not shown again after switching. Problem is, that there's still a '_chatViewControllersometimes, because the switch was too fast. Usingdispatch_afterlooks like the most reliable to me incallControllerDidJoinCall` (I'd go for 0.5, since the animation is 0.3).

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@SystemKeeper SystemKeeper merged commit 6d0340f into master Feb 2, 2023
@SystemKeeper SystemKeeper deleted the breakout-rooms branch February 2, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃枛 Breakout rooms
2 participants