Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakout rooms follow up #1093

Merged
merged 5 commits into from Feb 24, 2023
Merged

Breakout rooms follow up #1093

merged 5 commits into from Feb 24, 2023

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Feb 24, 2023 •
edited

  • Update room locally before joining breakout room
  • Allow to request assistance in breakout rooms
  • Filter out breakout rooms with lobby enabled

Follow up #981

@Ivansss
Update room locally before switching to breakout room.
65f5ace 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Add check in NCChatTitleView setTitle func.
df93fae 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Allow to request assistance in breakout rooms.
5cc5a5d 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Filter out breakout rooms with lobby enabled.
bd5a41f 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Do not request assistance if user is a moderator.
df9945f 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@SystemKeeper SystemKeeper merged commit 184adc9 into master Feb 24, 2023
@SystemKeeper SystemKeeper deleted the breakout-rooms-follow-up branch February 24, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ivansss @SystemKeeper