Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat scroll position when loading multiples blocks #1099

Merged
merged 1 commit into from Mar 1, 2023

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Mar 1, 2023

The unread messages indicator was misplaced when loading multiple blocks.
With this PR we force the chat view to keep current scroll position.
Also, the animation when adding new messages seems smoother now.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍
Might help with #992 maybe?

@SystemKeeper SystemKeeper merged commit 58246d6 into master Mar 1, 2023
@SystemKeeper SystemKeeper deleted the fix-chat-scroll-position branch March 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants