Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity check for update participants notification #1122

Merged
merged 1 commit into from Mar 10, 2023

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Mar 9, 2023

Not all room participants events contain roomid or users, so we need to check those values before adding them to userinfo dictionary.
This PR fixes app crash when receiving a room participants event for leaving the call (when a moderator presses "End call for everyone")

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thx!

@SystemKeeper SystemKeeper merged commit 62e3ca3 into master Mar 10, 2023
@SystemKeeper SystemKeeper deleted the sanity-check-room-participants-event branch March 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants