Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show submit button on the right of new Task input field #2075

Closed
ItsIgnacioPortal opened this issue Aug 15, 2022 · 2 comments · Fixed by #2226
Closed

[Feature Request] Show submit button on the right of new Task input field #2075

ItsIgnacioPortal opened this issue Aug 15, 2022 · 2 comments · Fixed by #2226

Comments

@ItsIgnacioPortal
Copy link

2022_08_15_20_27_17_Window

I think clicking that icon should do the same as pressing the enter key. I thought my instance was broken for quite a while until I realized it actually expects the user to press the enter key.

I'm logging this as a bug because if this isn't a broken button, I don't know why it was put there in the first place

@raimund-schluessler
Copy link
Member

This for sure is not a bug. It simply visualizes what this input field is supposed to do: add a Task. Besides, why should a submit/create button be on the left and provide no feedback when hovered, unlike every other button in the app? And if you ever used the Google search engine, you might be used to it: The magnifying glass icon on the left just does nothing and is not a button.
Screenshot 2022-08-16 at 21-55-09 Google

But I agree, that we could show a submit button on the right of the input field, similar to how it's done in the new TextField component of nextcloud/vue:
Screenshot 2022-08-16 at 21-59-00 Nextcloud Vue Style Guide

@raimund-schluessler raimund-schluessler changed the title [Bug] Make the "+" icon actually add a task. [Feature Request] Make the "+" icon actually add a task. Aug 16, 2022
@raimund-schluessler raimund-schluessler added this to the 0.14.5 milestone Aug 19, 2022
@raimund-schluessler raimund-schluessler changed the title [Feature Request] Make the "+" icon actually add a task. [Feature Request] Show submit button on the right of new Task input field Aug 19, 2022
@girugamoz
Copy link

My two cents: Google tries to avoid confusion like OP's: They show the magnifying glass icon as slightly darker than the input's font color, the same color as the input field's borders. This makes it more clear that the icon is not interactive. Maybe the same could be done here, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants