Tasks set in status "COMPLETED" by other means still appears uncompleted until Completion % set to 100

[koying]

Steps to reproduce

1. Use, e.g., Android app "Tasks" to set a task as completed
2. See that task still appear in uncompleted task list

Expected behavior

Only the completion status to be taken into account (STATUS:COMPLETED)

Actual behaviour

STATUS and percentage seems to be taken into account

Tasks app version

0.15.0

CalDAV-clients used

Android Tasks

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

None

Database engine version

None

PHP engine version

None

Nextcloud version

No response

Updated from an older installed version or fresh install

None

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

[raimund-schluessler]

The problem is likely not that PERCENT-COMPLETE is not 100%, but that the COMPLETED property is missing, see https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.2.1.

Could you please export one of these tasks as ICS file (in the sidebar, click export) to check how its properties do look like?

[koying]

Here you are:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:+//IDN tasks.org//android-130605//EN
BEGIN:VTODO
CREATED:20240101T104632Z
DTSTAMP:20240101T094745Z
LAST-MODIFIED:20240101T094745Z
STATUS:COMPLETED
SUMMARY:Test completion
UID:1ca8f0ee-fb86-49c9-a4a9-7c696f6c970e
END:VTODO
END:VCALENDAR

Both Android Tasks and Home Assistant Todo are aligned on this, just not the Nextcloud app...
Tad more subtile: For Android Task, STATUS:COMPLETED is enough, but I see it sets COMPLETED and PERCENT itself

BEGIN:VCALENDAR
VERSION:2.0
PRODID:+//IDN tasks.org//android-130605//EN
BEGIN:VTODO
DTSTAMP:20240101T100221Z
UID:ca277d0b-5992-40f7-8575-f2de8883920a
CREATED:20240101T110127Z
LAST-MODIFIED:20240101T100142Z
SUMMARY:Test completion
STATUS:COMPLETED
COMPLETED:20240101T100142Z
PERCENT-COMPLETE:100
END:VTODO
END:VCALENDAR

So the issue is on the Homeassistant side, I guess

[raimund-schluessler]

Yes, I think that is a bug by Homeassistant. It should set COMPLETED:20240101T100142Z as well. However, I guess we could work around this by checking for STATUS:COMPLETED here as well:

tasks/src/models/task.js

Lines 259 to 261 in 68f3747

	get closed() {
	return this._completed || this._status === 'CANCELLED'
	}

But it should nonetheless be adjusted in Homeassistant, as this might well lead to issues with other apps as well.

[raimund-schluessler]

I added a PR to adjust the behaviour of the Tasks app. However, other apps will likely still interpret a task with missing COMPLETED property as uncompleted, e.g. Nextcloud server does it.