Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion countdown cancelation not working since the last popover unification #49

Closed
3 tasks
skjnldsv opened this issue Feb 16, 2017 · 8 comments
Closed
3 tasks
Labels

Comments

@skjnldsv
Copy link
Member

Since nextcloud/server#3024

  • Clicking the cancel button still delete the task
  • Design is broken
  • Does not fit the guidelines ⚠️
@raimund-schluessler
Copy link
Member

The complete sidebar navigation is broken on Nextcloud server current master. Neither the navigation between calendars or collections nor the dropdown menu for the lists is working.

Some changes on server seriously fucked up the navigation.

@raimund-schluessler raimund-schluessler changed the title Deletion countdown cancelation not working since the last popover unification Navigation and lists menu broken on Nextcloud 12 Feb 17, 2017
@raimund-schluessler
Copy link
Member

Can someone explain to me why links to e.g.

nextcloud/index.php/apps/tasks#/collections/all

are newly translated to

nextcloud/index.php/apps/tasks#!/collections/all#%2Fcollections%2Fall

? This messes up the navigation of the app. I would be grateful for the link to the respective server issue. Maybe @skjnldsv or @MorrisJobke can help?

@MorrisJobke
Copy link
Member

We don't provide any JS routing in the server :/ So I don't know why this should be screwed :(

@raimund-schluessler
Copy link
Member

Weird. This are simple links like <a href="#/collections/current"></a> for example. And they are all rewritten. I will try to investigate.

@raimund-schluessler
Copy link
Member

Can someone confirm this? Maybe this is a problem with my setup.

@raimund-schluessler
Copy link
Member

Ok, sorry for the fuss. The problem is AngularJS 1.6. I was on a branch where I updated the dependencies. Updating AngularJS screwed up the navigation and I didn't noticed that until I also updated the server. Hence, my misconception what caused this.

I will fix the dropdown.

@raimund-schluessler raimund-schluessler changed the title Navigation and lists menu broken on Nextcloud 12 Deletion countdown cancelation not working since the last popover unification Feb 18, 2017
@raimund-schluessler
Copy link
Member

All issues should be fixed in #51 now.

@raimund-schluessler
Copy link
Member

New PR in #53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants