Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Images as base64 embedded Image Content #392

Closed
enboig opened this issue Oct 30, 2019 · 1 comment
Closed

Embed Images as base64 embedded Image Content #392

enboig opened this issue Oct 30, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@enboig
Copy link

enboig commented Oct 30, 2019

And option to embed an image would make documents more portable. Maybe a checkbox when inserting image or a "right-click" option of already added images.

@mejo-
Copy link
Member

mejo- commented Nov 1, 2022

Unfortunately, embedding base64 encoded images in markdown can have unexpected security implications. E.g. it might be a SVG with embedded scripts.

But we completely revamped the way how uploaded images are handled in Text recently. When you upload an image to a text document, it gets uploaded to an attachment folder that is automatically shared together with the markdown file and cleaned up once the markdown file gets removed. Would this solve your problem?

Closing the issue for now, but don't hesitate to comment and/or reopen if you still see a need to discuss this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants