Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes for embedding / previewing content #5270

Closed
8 tasks
Tracked by #42550
max-nextcloud opened this issue Jan 17, 2024 · 1 comment · Fixed by #5399
Closed
8 tasks
Tracked by #42550

Nodes for embedding / previewing content #5270

max-nextcloud opened this issue Jan 17, 2024 · 1 comment · Fixed by #5399
Assignees
@max-nextcloud
Labels
enhancement New feature or request
Milestone
Nextcloud 29

Comments

@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Jan 17, 2024 •
edited by juliushaertl

Goal

When editing a markdown file
I want to be able to embed content from another app
either as a preview or editable

Approach

  • define a markdown syntax (preliminary)
  • add parsing to markdown-it
  • add a node type for previews
  • render the previews when syntax is in the markdown
  • ensure it serializes back to the same format
  • allow removing a preview
  • allow inserting a preview
  • Revert Add interactive flag to reference widgets #5313 and move the interactive flag to the new node type

Describe alternatives you've considered
Define all links in the form of a node that can either be a simple link or a preview. However normal links are inline and previews would be block content.

Additional context
@max-nextcloud max-nextcloud added the enhancement New feature or request label Jan 17, 2024
@max-nextcloud max-nextcloud self-assigned this Jan 17, 2024
@max-nextcloud max-nextcloud added this to the Nextcloud 29 milestone Jan 17, 2024
@juliushaertl juliushaertl mentioned this issue Jan 18, 2024
Closed
7 tasks
@juliushaertl juliushaertl mentioned this issue Jan 26, 2024
Merged
@max-nextcloud max-nextcloud mentioned this issue Jan 30, 2024
Closed
@juliushaertl
Copy link
Member

@max-nextcloud Added a checkbox to revert #5313 in your PR

@max-nextcloud max-nextcloud mentioned this issue Feb 20, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-nextcloud max-nextcloud

Labels
enhancement New feature or request
Projects
📝 Office team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging a pull request may close this issue.

Enh/preview links nextcloud/text
2 participants
@juliushaertl @max-nextcloud