Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention users #92

Closed
juliushaertl opened this issue Jun 22, 2019 · 2 comments · Fixed by #2748
Closed

Mention users #92

juliushaertl opened this issue Jun 22, 2019 · 2 comments · Fixed by #2748
Assignees
Labels
1. to develop enhancement New feature or request feature: formatting Features related to text formatting and node types

Comments

@juliushaertl
Copy link
Member

It should be possible to mention users

@juliushaertl juliushaertl created this issue from a note in 📄 Collaborative text editor (Out of scope) Jun 22, 2019
@juliushaertl juliushaertl added enhancement New feature or request feature: formatting Features related to text formatting and node types labels Jun 22, 2019
@juliushaertl juliushaertl added this to the 3.0 📝 milestone Jun 22, 2019
@stale stale bot added the wontfix label Aug 22, 2019
@nextcloud nextcloud deleted a comment from stale bot Aug 22, 2019
@juliushaertl juliushaertl modified the milestones: 3.0 📝, 19.0.0 Jan 16, 2020
@MorrisJobke MorrisJobke modified the milestones: 19.0.0, Nextcloud 20 Jul 7, 2020
@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 21 Oct 3, 2020
@rullzer rullzer removed this from the Nextcloud 21 milestone Mar 1, 2021
@jancborchardt jancborchardt added this to 🧭 Planning evaluation (don't pick) in 📝 Office team via automation Sep 2, 2021
@juliushaertl
Copy link
Member Author

As discussed with @mejo- this would be relatively straight forward to implement on the frontend side now with the picker from #1961

Further steps would be:

  • Clarify on markdown representation (e.g. could use the profile url as a link [@User display name](https://cloud.example.com/u/userid))
  • Clarify individual implementation steps in detail
    1. Plain mentions in the document
    2. Notify users about mentions (with proper cleanup once a mention gets removed again)
    3. Enhanced UX (e.g. suggest to share if a mentioned user doesn't have access to the document yet)

Should also be aligned with the ongoing effort on the Collabora integration at nextcloud/richdocuments#1380

@juliushaertl
Copy link
Member Author

juliushaertl commented Jul 11, 2022

Reference on how the formats are converted

  • markdown document => markdown-it => html (markdown-it-mentions)
  • html => tiptap => rendering editor (tiptap needs to understand the html output from the above step)
  • tiptap => prosemirror-markdown => markdown (tiptap needs to generate the same markdown format that is used in the first step)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement New feature or request feature: formatting Features related to text formatting and node types
Projects
Archived in project
📝 Office team
🧭 Planning evaluation (don't pick)
Development

Successfully merging a pull request may close this issue.

5 participants