Feature/use signal cli json rpc #579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
…ition to the deprectated https://gitlab.com/morph027/signal-cli-dbus-rest-api. Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
rotdrop
force-pushed
the
feature/use-signal-cli-json-rpc
branch
2 times, most recently
from
c8c570a
to
16d44d0
Compare
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
rotdrop
force-pushed
the
feature/use-signal-cli-json-rpc
branch
from
16d44d0
to
9bda470
Compare
|
I just do not know what is the cause of the failure the that obscure Also: the output of that funny test does not provide any information about how to fix this (probably: pseudo) failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signal-cli comes with its own HTTP endpoint for JSON RPC calls since signal-cli 0.11.5.
This means that there is no longer a need for any intermediate wrappe, so lets just use the native HTTP endpoint of Signal-Cli.
The old methods are tried in turn if the native end-point is not reachable.
This PR maybe also fixes #573.