Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show TOTP directly below password field #250

Closed
papst01 opened this issue Apr 26, 2018 · 1 comment
Closed

Show TOTP directly below password field #250

papst01 opened this issue Apr 26, 2018 · 1 comment

Comments

@papst01
Copy link

papst01 commented Apr 26, 2018

It should be prevented, that an attacker could get knowledge of the correct password. Till now, the login process works (as far as I understand it) this way:

  • type in user name
  • switch to the password field and type it in,
  • press Enter [password will be checked] and if correct
  • the TOTP-field is shown.
  • type in the TOTP
  • press ENTER and if correct, the login worked

For me this is a security flaw. It is not necessary to inform the attacker, that he know's the correct password.

The only right way - in my eyes - should be: If the admin has added the TOTP app (and at least one user has it activated,) show the TOTP field below the password field on the login screen from the start. Password and TOTP are checked.

@ChristophWurst
Copy link
Member

This is a duplicate (can't find the original ticket right now, sorry).

For me this is a security flaw. It is not necessary to inform the attacker, that he know's the correct password.

We already have bruteforce protection in place that should prevent attackers trying to guess the 2fa secret: nextcloud/server#4434.

Moreover I've not yet seen any platform that would handle logins this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants