Scope cs-fixer to avoid dependency hell #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
force-pushed
the
fix/cs-fixer-dep-hell
branch
from
bb3799e
to
afc92a7
Compare
The cs-fixer pulls in symfony and friends, which gets autoloader with the Nextcloud process and causes incompatibilities with Nextcloud's copy of Symfony. There is no reason to autoload this by default. We can use the composer bin plugin instead. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/cs-fixer-dep-hell
branch
from
afc92a7
to
4122ccf
Compare
jotoeri
added a commit
to nextcloud/forms
that referenced
this pull request
Apr 6, 2022
Taken from nextcloud/twofactor_webauthn#132 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
added a commit
to nextcloud/forms
that referenced
this pull request
Apr 6, 2022
Taken from nextcloud/twofactor_webauthn#132 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
added a commit
to nextcloud/forms
that referenced
this pull request
Apr 6, 2022
Taken from nextcloud/twofactor_webauthn#132 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
added a commit
to nextcloud/forms
that referenced
this pull request
Apr 6, 2022
Taken from nextcloud/twofactor_webauthn#132 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
added a commit
to nextcloud/forms
that referenced
this pull request
Apr 6, 2022
Taken from nextcloud/twofactor_webauthn#132 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
jotoeri
added a commit
to nextcloud/forms
that referenced
this pull request
Apr 6, 2022
Taken from nextcloud/twofactor_webauthn#132 Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cs-fixer pulls in symfony and friends, which gets autoloaded with
the Nextcloud process and causes incompatibilities with Nextcloud's copy
of Symfony. There is no reason to autoload this by default. We can use
the composer bin plugin instead.
Fixes #121