Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(challenge): invert icon based on theme #309

Merged
merged 1 commit into from
Dec 13, 2022
Merged

fix(challenge): invert icon based on theme #309

merged 1 commit into from
Dec 13, 2022

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Dec 12, 2022

Fix #308

Before

grafik

After

Light theme Dark theme
webauthn-light webauthn-dark

@st3iny
fix(challenge): invert icon based on theme
8080bb0 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added bug Something isn't working 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. labels Dec 12, 2022
@st3iny st3iny added this to the 1.1.0 milestone Dec 12, 2022
@st3iny st3iny self-assigned this Dec 12, 2022
@st3iny
Copy link
Member Author

st3iny commented Dec 12, 2022

cc @nursoda Feel free to test.

@st3iny
Copy link
Member Author

st3iny commented Dec 12, 2022

/backport to stable1.0

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Dec 12, 2022
@nursoda
Copy link

nursoda commented Dec 12, 2022

I confirm this fixes issue #308 for me.

@st3iny
Copy link
Member Author

st3iny commented Dec 13, 2022

Failure of static analysis is not related and passes locally.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 13, 2022
@ChristophWurst ChristophWurst merged commit 952b5ad into main Dec 13, 2022
@ChristophWurst ChristophWurst deleted the fix/308/invert-challenge-icon branch December 13, 2022 09:34
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 13, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Dec 13, 2022
@st3iny st3iny mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees

@st3iny st3iny

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Dark icon is shown in dark theme
3 participants
@st3iny @nursoda @ChristophWurst