Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI based updater #45

Merged
merged 49 commits into from
Nov 25, 2016
Merged

CLI based updater #45

merged 49 commits into from
Nov 25, 2016

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 27, 2016

  • add more test cases
  • add message that after the "code update" the user needs to call ./occ upgrade (or call it directly afterwards from within the console command - problem here is regarding properly forwarding the output of the called script async)

How to test

How does it look

bildschirmfoto 2016-11-09 um 00 05 43

@MorrisJobke
Copy link
Member Author

This is ready for reviewing @nickvergessen @rullzer @LukasReschke

Use phar in https://github.com/nextcloud/updater/releases/tag/0.1 to actually test it ;)

@rullzer
Copy link
Member

rullzer commented Nov 21, 2016

Test fail.
Tried a few updates locally and it worked like a charm!

I'll try to have a bit deeper look into the code now.

@@ -0,0 +1,10 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add

    "config": {
       "optimize-autoloader": true,
       "classmap-authoritative": true
     },

For more secure autoloader? That way it will only look trough it lists of known files (so the created list of the dumpautoloader command). Which means no loading magic and accidentially loading a wrong file.

@rullzer
Copy link
Member

rullzer commented Nov 21, 2016

We need more testers but in general yes. Lets do this 👍

@MorrisJobke
Copy link
Member Author

Version 1.0 is build: https://github.com/nextcloud/updater/releases/tag/1.0

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
* not supported before Nextcloud 11 -> causes failure in occ calls

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member Author

CI says 🚀

@MorrisJobke MorrisJobke merged commit 6852eaa into master Nov 25, 2016
@MorrisJobke MorrisJobke deleted the cli-updater branch November 25, 2016 15:07
@MorrisJobke MorrisJobke modified the milestones: 1.0, Nextcloud 11.0 Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants