Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update composer deps and box build workflow #477

Closed
wants to merge 3 commits into from
Closed

fix: update composer deps and box build workflow #477

wants to merge 3 commits into from
+8,576 −2,958

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 7, 2023 •
edited

  • Move humbug/box to a dev dependency
  • Update bamarni/composer-bin-plugin

@skjnldsv skjnldsv requested a review from come-nc June 7, 2023 07:01
@skjnldsv skjnldsv changed the title fix: update index.php and updater.phar fix: update index.php Jun 7, 2023
@skjnldsv
fix: update index.php and updater.phar
8bb8262 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title fix: update index.php fix: update index.php and updater.phar Jun 7, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 7, 2023

God dammit, how do I get check-same-code-base to pass...........

@skjnldsv skjnldsv self-assigned this Jun 7, 2023
@skjnldsv skjnldsv force-pushed the fix/same-code-base branch 4 times, most recently from fec137b to 250ad95 Compare June 7, 2023 07:49
@skjnldsv skjnldsv force-pushed the fix/same-code-base branch 5 times, most recently from 55716e9 to 4b824ea Compare June 7, 2023 08:26
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 7, 2023

installed.php keeps changing, it's driving me insane ^^"

@skjnldsv skjnldsv force-pushed the fix/same-code-base branch 2 times, most recently from d3f6077 to 25dd7ff Compare June 7, 2023 08:47
@skjnldsv
fix: update composer deps and box build workflow
d8887fb 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title fix: update index.php and updater.phar fix: update composer deps and box build workflow Jun 7, 2023
@come-nc
Install dependencies in workflows
ce42f2a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Collaborator

come-nc commented Jun 8, 2023

Tests CI are failing because they use 7.4 which is not supported by our dependencies anymore.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 8, 2023

I gave up, lost too much time in that rabbit hole yesterday ^^"

@come-nc come-nc mentioned this pull request Jun 8, 2023
Merged
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@come-nc
Copy link
Collaborator

come-nc commented Jan 23, 2024

Included in #475

@come-nc come-nc closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@skjnldsv skjnldsv

Labels
2. developing
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @come-nc @blizzz