Enforce https #495
Merged
Enforce https #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
enhancement
julien-nc
force-pushed
the
fix/noid/enforce-https
branch
from
48cbb72
to
2bc8b3c
Compare
|
Can we disable the check in debug mode ? Otherwise local development becomes a bit harder |
julien-nc
force-pushed
the
fix/noid/enforce-https
branch
from
2bc8b3c
to
991fca0
Compare
juliushaertl
approved these changes
Aug 31, 2022
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/noid/enforce-https
branch
from
991fca0
to
8dd6baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing the login flow with HTTP reveals/exposes secret information. Login and code endpoints are now rejecting HTTP requests.
OpenId specs regarding TLS are not very clear but can be interpreted as "better use HTTPS".
I took the opportunity to make some polishing to the Login controller. I hope this is not too out of scope 馃榿.