Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psalm checks #765

Merged
merged 2 commits into from Jan 23, 2024
Merged

Add psalm checks #765

merged 2 commits into from Jan 23, 2024

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Jan 19, 2024

  • bump min NC version to 25 to use OCP\Cache\CappedMemoryCache
  • add nextcloud/ocp:dev-stable25 composer dependency for psalm check
  • add psalm check GH action
  • fix all psalm errors
  • add php-cs check
  • run php-cs fix
  • use Psr\Log\LoggerInterface instead of deprecated OCP\ILogger

@julien-nc julien-nc added the enhancement New feature or request label Jan 19, 2024
@julien-nc julien-nc force-pushed the enh/add-psalm-checks branch 4 times, most recently from 6477ac0 to c206770 Compare January 19, 2024 14:00
… php-cs:check run php-cs:fix

remove 'output' command option that is already set in OC\Core\Command\base

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc merged commit 556b71d into main Jan 23, 2024
38 checks passed
@julien-nc julien-nc deleted the enh/add-psalm-checks branch January 23, 2024 15:22
@julien-nc julien-nc mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants