enable opening a single shared file #1242

vanpertsch · 2022-05-11T10:23:19Z

Signed-off-by: Vanessa Pertsch vanessa.pertsch@posteo.de

First steps towards #644 together with nextcloud/server#33347

max-nextcloud · 2022-05-18T13:20:11Z

@vanpertsch there's some lint issues still in my commit. Sorry for that - did not clean it up. Could you fix them?

src/views/Viewer.vue

src/services/Viewer.js

src/utils/fileUtils.js

PVince81 · 2022-06-08T06:25:45Z

@max-nextcloud would you be able to take over and finish this PR ?

max-nextcloud · 2022-06-08T16:21:10Z

@PVince81 I won't have time for it this week - but i can get to it next week.

max-nextcloud · 2022-06-15T13:05:16Z

I rebased it for now. I'll look into adding a test tomorrow. Other than that i think it should be done.

artonge

Code looks good, but not sure why we need to introduce the possibility to render the viewer in another element?

skjnldsv · 2022-06-21T16:22:06Z

not sure why we need to introduce the possibility to render the viewer in another element?

e.g. using viewer for single-files public shares.

PVince81 · 2022-07-14T07:51:27Z

@max-nextcloud if you're done adding the test please set the label to "3 - To review" and ask for another review

PVince81 · 2022-08-10T20:39:55Z

/compile amend /

PVince81 · 2022-08-10T20:40:10Z

@max-nextcloud is this ready for re-review ?

max-nextcloud · 2022-08-11T09:46:31Z

@max-nextcloud is this ready for re-review ?

Yes.

As i said in #1242 (comment) - i'm not sure how best to resolve the dependency between this change and the one in files_server. Other than that i think this is good to go.

skjnldsv · 2022-08-17T15:27:39Z

cypress test requires nextcloud/server#33347 to pass - which in turn depends on this to work. Not sure how best to resolve this.

I'd appreciate some reviews on the general approach as a start. Can probably clean up a bunch more stuff that is not used anymore now. Tried to get it working as a start.

Let's merge this one then server

szaimen · 2022-08-17T16:03:52Z

@skjnldsv is testing needed? I could do with

docker run -it \
-p 127.0.0.1:8443:443 \
-e VIEWER_BRANCH=enable-share-single-file \
-e SERVER_BRANCH=feature/use-viewer-for-singe-file-shares \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

PVince81 · 2022-08-26T07:04:42Z

@max-nextcloud server PR nextcloud/server#33347 got merged

Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.de>

max-nextcloud · 2022-08-26T08:00:04Z

@max-nextcloud server PR nextcloud/server#33347 got merged

oh my... should have made it more clear it depends on this...

Rebasing this now so we can get it in fast.

Signed-off-by: Max <max@nextcloud.com>

Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com>

Signed-off-by: Max <max@nextcloud.com>

This enables scrolling single file share views so the download button below an image becomes visible. Signed-off-by: Max <max@nextcloud.com>

max-nextcloud · 2022-08-26T09:08:33Z

/compile amend .

max-nextcloud · 2022-08-26T10:25:25Z

/compile amend /

Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

skjnldsv · 2022-09-06T09:14:45Z

src/components/Images.vue

+			// only change zoomRatio when multiple files are in the fileList. Disable for single shared files
+			if (this.fileList.length > 1) {
+				this.zoomRatio = newZoomRatio
+			}


@max-nextcloud We can load a single file without being inline.
This is a regression

Good point. I'll fix it.

So i guess a good criterion will be if el is set.

Zoom should only be disabled on single shared files. See #1242 (review) Signed-off-by: Max <max@nextcloud.com>

Zoom should only be disabled on single shared files. See #1242 (review) Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

vanpertsch requested review from skjnldsv and max-nextcloud May 11, 2022 10:23

vanpertsch force-pushed the enable-share-single-file branch from 7f0527c to 9e87dd9 Compare May 11, 2022 12:20

skjnldsv added enhancement New feature or request 2. developing Work in progress labels May 11, 2022

skjnldsv added this to the Nextcloud 25 milestone May 11, 2022

vanpertsch force-pushed the enable-share-single-file branch from 9e87dd9 to 4fe72e2 Compare May 18, 2022 10:20

vanpertsch force-pushed the enable-share-single-file branch 2 times, most recently from dc8006f to 035136d Compare May 18, 2022 14:18

skjnldsv reviewed May 19, 2022

View reviewed changes

src/views/Viewer.vue Outdated Show resolved Hide resolved

skjnldsv reviewed May 19, 2022

View reviewed changes

src/services/Viewer.js Outdated Show resolved Hide resolved

skjnldsv reviewed May 19, 2022

View reviewed changes

src/services/Viewer.js Outdated Show resolved Hide resolved

skjnldsv reviewed May 19, 2022

View reviewed changes

src/utils/fileUtils.js Outdated Show resolved Hide resolved

vanpertsch force-pushed the enable-share-single-file branch 2 times, most recently from 7dbc84c to 6043727 Compare May 23, 2022 14:26

PVince81 assigned max-nextcloud Jun 8, 2022

max-nextcloud force-pushed the enable-share-single-file branch from 6043727 to 28f58dc Compare June 15, 2022 13:03

max-nextcloud force-pushed the enable-share-single-file branch from 28f58dc to adbea59 Compare June 15, 2022 13:06

PVince81 requested review from artonge, skjnldsv, CarlSchwan and Pytal June 17, 2022 07:48

artonge approved these changes Jun 21, 2022

View reviewed changes

max-nextcloud force-pushed the enable-share-single-file branch from adbea59 to 9b3bdc4 Compare July 25, 2022 18:14

max-nextcloud mentioned this pull request Aug 2, 2022

Rely on viewer app to open single shared .md file nextcloud/text#2772

Open

nextcloud-command force-pushed the enable-share-single-file branch from dd60339 to 013be7f Compare August 10, 2022 20:41

max-nextcloud force-pushed the enable-share-single-file branch from 013be7f to 5a4ceca Compare August 11, 2022 09:43

skjnldsv mentioned this pull request Aug 12, 2022

25.0.0 beta 1 nextcloud/server#33505

Merged

skjnldsv mentioned this pull request Aug 18, 2022

25.0.0 beta 2 nextcloud/server#33592

Merged

blizzz mentioned this pull request Aug 24, 2022

25.0.0 beta 3 nextcloud/server#33674

Merged

enable opening a single shared file

4b1596e

Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.de>

max-nextcloud and others added 4 commits August 26, 2022 10:05

render viewer content in element instead of modal

8c58437

Signed-off-by: Max <max@nextcloud.com>

disable zooming for single shared file

cacc56c

Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com>

test: basic cypress test for single file share

4b9605b

Signed-off-by: Max <max@nextcloud.com>

fix: keep body overflow when rendering in element

bba1ae4

This enables scrolling single file share views so the download button below an image becomes visible. Signed-off-by: Max <max@nextcloud.com>

max-nextcloud force-pushed the enable-share-single-file branch from 5a4ceca to 9056332 Compare August 26, 2022 08:09

build: js

19921a9

Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

nextcloud-command force-pushed the enable-share-single-file branch from 9056332 to 19921a9 Compare August 26, 2022 10:27

max-nextcloud merged commit c51a5bf into master Aug 26, 2022

max-nextcloud deleted the enable-share-single-file branch August 26, 2022 11:08

blizzz mentioned this pull request Aug 30, 2022

25.0.0 beta 4 nextcloud/server#33762

Merged

skjnldsv reviewed Sep 6, 2022

View reviewed changes

max-nextcloud added a commit that referenced this pull request Sep 6, 2022

fix: bring back zoom on single open files

37214f5

Zoom should only be disabled on single shared files. See #1242 (review) Signed-off-by: Max <max@nextcloud.com>

max-nextcloud mentioned this pull request Sep 6, 2022

fix: bring back zoom on single open files #1363

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable opening a single shared file #1242

enable opening a single shared file #1242

vanpertsch commented May 11, 2022 •

edited by max-nextcloud

Loading

max-nextcloud commented May 18, 2022

PVince81 commented Jun 8, 2022

max-nextcloud commented Jun 8, 2022

max-nextcloud commented Jun 15, 2022

artonge left a comment

skjnldsv commented Jun 21, 2022 •

edited

Loading

PVince81 commented Jul 14, 2022

PVince81 commented Aug 10, 2022

PVince81 commented Aug 10, 2022

max-nextcloud commented Aug 11, 2022 •

edited

Loading

skjnldsv commented Aug 17, 2022

szaimen commented Aug 17, 2022 •

edited

Loading

PVince81 commented Aug 26, 2022

max-nextcloud commented Aug 26, 2022

max-nextcloud commented Aug 26, 2022

max-nextcloud commented Aug 26, 2022

skjnldsv Sep 6, 2022

max-nextcloud Sep 6, 2022

max-nextcloud Sep 6, 2022

enable opening a single shared file #1242

enable opening a single shared file #1242

Conversation

vanpertsch commented May 11, 2022 • edited by max-nextcloud Loading

max-nextcloud commented May 18, 2022

PVince81 commented Jun 8, 2022

max-nextcloud commented Jun 8, 2022

max-nextcloud commented Jun 15, 2022

artonge left a comment

Choose a reason for hiding this comment

skjnldsv commented Jun 21, 2022 • edited Loading

PVince81 commented Jul 14, 2022

PVince81 commented Aug 10, 2022

PVince81 commented Aug 10, 2022

max-nextcloud commented Aug 11, 2022 • edited Loading

skjnldsv commented Aug 17, 2022

szaimen commented Aug 17, 2022 • edited Loading

PVince81 commented Aug 26, 2022

max-nextcloud commented Aug 26, 2022

max-nextcloud commented Aug 26, 2022

max-nextcloud commented Aug 26, 2022

skjnldsv Sep 6, 2022

Choose a reason for hiding this comment

max-nextcloud Sep 6, 2022

Choose a reason for hiding this comment

max-nextcloud Sep 6, 2022

Choose a reason for hiding this comment

vanpertsch commented May 11, 2022 •

edited by max-nextcloud

Loading

skjnldsv commented Jun 21, 2022 •

edited

Loading

max-nextcloud commented Aug 11, 2022 •

edited

Loading

szaimen commented Aug 17, 2022 •

edited

Loading