Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Enable app specific preview URL #1536

Merged
merged 5 commits into from Feb 1, 2023
Merged

[stable25] Enable app specific preview URL #1536

merged 5 commits into from Feb 1, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 1, 2023

Manual backport of #1525 to stable25

@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews labels Feb 1, 2023
starypatyk and others added 4 commits February 1, 2023 17:11
@starypatyk @szaimen
App specific preview URL
afecab3 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
@starypatyk @szaimen
After review - new dedicated property - previewUrl
15fe724 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
@starypatyk @artonge @szaimen
Apply suggestions from code review
c499044 
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com>
Signed-off-by: Dariusz Olszewski <8277636+starypatyk@users.noreply.github.com>
@starypatyk @szaimen
Avoid using source if previewUrl is set
e4d56de 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
@szaimen szaimen added this to the Nextcloud 25.0.4 milestone Feb 1, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Feb 1, 2023

/compile /

@szaimen szaimen mentioned this pull request Feb 1, 2023
Merged
@nextcloud-command
Compile assets
621fe70 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@ChristophWurst
Copy link
Member

We generally don't backport features. What do we need this for?

@szaimen szaimen added bug Something isn't working and removed enhancement New feature or request labels Feb 1, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Feb 1, 2023

We generally don't backport features. What do we need this for?

It is rather a bugfix IIRC: nextcloud/photos#1602

@ChristophWurst
Copy link
Member

We generally don't backport features. What do we need this for?

It is rather a bugfix IIRC: nextcloud/photos#1602

Thanks. Bottom of the description explains how the first part is a fix and the second is an enhancement. Would it make sense to backport only the fix for 25 and leave the enhancement for 26?

@szaimen
Copy link
Contributor Author

szaimen commented Feb 1, 2023

Thanks. Bottom of the description explains how the first part is a fix and the second is an enhancement. Would it make sense to backport only the fix for 25 and leave the enhancement for 26?

Not sure. Cc @skjnldsv @starypatyk

@skjnldsv
Copy link
Member

skjnldsv commented Feb 1, 2023

We're enhancing the fix. LGTM

@starypatyk
Copy link
Contributor

Thanks. Bottom of the description explains how the first part is a fix and the second is an enhancement. Would it make sense to backport only the fix for 25 and leave the enhancement for 26?

Not sure. Cc @skjnldsv @starypatyk

This can be considered an enhancement to Viewer that is necessary to have a complete fix in Photos. 😉

starypatyk
starypatyk approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@starypatyk starypatyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen merged commit b65bcea into stable25 Feb 1, 2023
@szaimen szaimen deleted the backport/1525/stable25 branch February 1, 2023 20:13
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starypatyk starypatyk starypatyk approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@pulsejet pulsejet Awaiting requested review from pulsejet

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
Nextcloud 25.0.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@szaimen @ChristophWurst @skjnldsv @starypatyk @nextcloud-command