fix 404 on blank.mp4 #1636
Merged
fix 404 on blank.mp4 #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We definetly don't want to do that. |
|
I think we should decide to ship it, I'm fine with it. |
skjnldsv
added
2. developing
hamza221
added
3. to review
|
Conflicting files |
skjnldsv
reviewed
May 4, 2023
src/components/Videos.vue
Outdated
| @@ -84,6 +84,8 @@ export default { | |||
| options() { | |||
| return { | |||
| autoplay: this.active === true, | |||
| // Used to reset the video streams https://github.com/sampotts/plyr#javascript-1 | |||
| blankVideo: '../img/blank.mp4', | |||
There was a problem hiding this comment.
do that even works?
Shouldn't it be a geenrateImgPath or something? 🤔
There was a problem hiding this comment.
imagePath is the function name
skjnldsv
added
2. developing
hamza221
force-pushed
the
bug/blank.mp4
branch
2 times, most recently
from
5f55350
to
e30b34c
Compare
hamza221
added
3. to review
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
skjnldsv
approved these changes
May 24, 2023
skjnldsv
added
4. to release
|
/backport to stable26 |
|
/backport to stable27 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable25 |
This was referenced May 24, 2023
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blank.mp4 file is used to prevent MEDIA_ERR_SRC_NOT_SUPPORTED
The default value of blankVideo prop is cdn.plyr.io/static/blank.mp4. The previous value would result into 404 because /index.php/s/blank.mp4 doesn't exist, alternatively we can ship Nextcloud with a blank.mp4 file by default if we don't want to query an external cdn