Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase z-index of SfxPopper instead of its children #1655

Merged
merged 1 commit into from
May 12, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 11, 2023

Each popper should have its own z-index, so setting the same z-index to all poppers prevent accessing sub-poppers.
Here we increase the z-index of all poppers container to not mess with their individual z-index.

Fix nextcloud/photos#1683

Before After
Screenshot from 2023-05-11 16-07-52 Screenshot from 2023-05-11 16-05-53

@artonge artonge enabled auto-merge May 11, 2023 14:06
@artonge artonge self-assigned this May 11, 2023
@artonge artonge requested a review from skjnldsv May 11, 2023 14:06
@artonge artonge added bug Something isn't working javascript Javascript related ticket labels May 11, 2023
@artonge artonge added this to the Nextcloud 27 milestone May 11, 2023
@artonge
Copy link
Contributor Author

artonge commented May 11, 2023

/backport to stable26

@artonge
Copy link
Contributor Author

artonge commented May 11, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label May 11, 2023
@artonge artonge added the 3. to review Waiting for reviews label May 11, 2023
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/sub_popper_use branch from 5f0acbf to 9648987 Compare May 12, 2023 10:45
@artonge artonge merged commit da4f2b8 into master May 12, 2023
@artonge artonge deleted the artonge/fix/sub_popper_use branch May 12, 2023 11:50
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't change "Stroke" and "Shadow" color in the editor
2 participants