fix: use filename to find current index #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
added
enhancement
kesselb
commented
Dec 30, 2023
...svg_xml_base64_PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCI-65943f.js
Outdated
Show resolved
Hide resolved
kesselb
force-pushed
the
bug/484/find-current-index-by-filename
branch
2 times, most recently
from
0787a5c
to
88a8731
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
bug/484/find-current-index-by-filename
branch
from
88a8731
to
403853d
Compare
skjnldsv
approved these changes
Jan 2, 2024
|
/compile amend / |
nextcloud-command
force-pushed
the
bug/484/find-current-index-by-filename
branch
from
403853d
to
a6168ef
Compare
kesselb
force-pushed
the
bug/484/find-current-index-by-filename
branch
2 times, most recently
from
3fce515
to
761e86f
Compare
|
/compile / |
|
/compile amend / |
nextcloud-command
force-pushed
the
bug/484/find-current-index-by-filename
branch
from
761e86f
to
ceb2c2f
Compare
|
I don't know what's wrong with the compile bot and/or CI. The cypress tests are working locally. |
|
Rebase and drop the compile changes |
The viewer component is usually used with a folder and the basename unique. However in photos, the fileList contains objects from multiple folders and the basename is not always unique. How to reproduce: - Create folder A and B - Upload an image to folder A and name it "Test" - Upload another image to folder B and also name it "Test" - Open photos - Click on the image from folder B - The image from folder A is shown To find the correct "currentIndex" we need filename (including the path). Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/484/find-current-index-by-filename
branch
from
ceb2c2f
to
274818d
Compare
Done ✔️ |
skjnldsv
added
4. to release
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
let's see |
|
/backport 274818d to stable28 |
backportbot-nextcloud
bot
added
the
backport-request
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #484
The viewer component is usually used with a folder and the basename unique.
However in photos, the fileList contains objects from multiple folders and the basename is not always unique.
How to reproduce:
To find the correct "currentIndex" we need filename (including the path).
My current understand is that fileInfo.filename should be always there, even if the remote file is not a dav file (e.g. attachments from mail). If that's not the case, we need to come up with an alternative solution.