Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing generateUrl #2325

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix: Add missing generateUrl #2325

merged 1 commit into from
Jun 7, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jun 4, 2024

No description provided.

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Jun 4, 2024
@hamza221 hamza221 self-assigned this Jun 4, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but did not test

@hamza221
Copy link
Contributor Author

hamza221 commented Jun 4, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 4, 2024
@hamza221
Copy link
Contributor Author

hamza221 commented Jun 4, 2024

/backport to stable29

@skjnldsv
Copy link
Member

skjnldsv commented Jun 7, 2024

/compile amend /

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 333ffe5 into master Jun 7, 2024
5 checks passed
@skjnldsv skjnldsv deleted the Fix/missing-generateurl branch June 7, 2024 09:31
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 7, 2024
@nextcloud nextcloud deleted a comment from backportbot bot Jun 7, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Jun 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants