Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requesttoken): Make sure to use the correct requesttoken in WebdavClient #2339

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

SystemKeeper
Copy link
Contributor

Fixes nextcloud/spreed#12529

Introduced in #2178 / #2179

Before the PR the getRequestToken was called when createClient was called, so it always contained the current value. After the PR getRequestToken is only called once when the headers object is created, so it will never change, which leads to being unable to open some pictures (see talk issue above).

…vClient

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Copy link

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, let's wait for a second opinion

@skjnldsv skjnldsv merged commit c8f422a into master Jun 19, 2024
30 checks passed
@skjnldsv skjnldsv deleted the fix/noid/requesttoken-refresh branch June 19, 2024 07:04
@SystemKeeper
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 19, 2024
@SystemKeeper
Copy link
Contributor Author

/backport to stable29

Copy link

backportbot bot commented Jun 19, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2339/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e870f7e2

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2339/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening pictures fails with CSRF error (wrong requesttoken send)
3 participants