Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit assets #42

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Commit assets #42

merged 1 commit into from
Mar 18, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 18, 2019

Currently the release script doesn't build them. So it won't do anything
if they are not there.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Currently the release script doesn't build them. So it won't do anything
if they are not there.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@skjnldsv
Copy link
Member

I would rather have the build script make sure the app is compiled?
It's quite annoying to have to rebase every time there is a compile config ^^

@ChristophWurst
Copy link
Member

I would rather have the build script make sure the app is compiled?

@MorrisJobke showed me the release script last week. We think that krankerl could do this, but this is not ready yet. I'm working on it, though: ChristophWurst/krankerl#451

@skjnldsv
Copy link
Member

Let's do this then :D

@skjnldsv skjnldsv merged commit 6c49b3e into master Mar 18, 2019
@skjnldsv skjnldsv deleted the fix/release_tarballs branch March 18, 2019 14:52
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants