delete within viewer, try #2

[jakobroehrl]

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de

[skjnldsv]

@jakobroehrl if you're stuck on the tests, do you want to find some time and do a call so I can fix them with you so you understand them a bit better?

[nickvergessen]

Once in, would be nice to backport this to 20 😁

[skjnldsv]

/compile amend /

[skjnldsv]

/compile amend /

[skjnldsv]

/compile amend /

[rakekniven]

Will this be backported to NC20?

[skjnldsv]

Hey, no. Viewer is too tightly bound with server

[jakobroehrl]

@skjnldsv
Tried it in NC21: Deleting is working on all files expect in the photo app, there is no delete icon.

[skjnldsv]

@jakobroehrl I guess we are not requesting the permissions in photos, so viewer is not aware of them?

[jakobroehrl]

@skjnldsv This could be true, could I do something to get this running?

[szaimen]

I guess the filesystem permission is missing for that?
You could try to add this to photos info.xml
https://github.com/nextcloud/maps/blob/master/appinfo/info.xml#L56-L58

[szaimen]

But this will also disable the possibility to limit the app to specific groups

[skjnldsv]

I guess the filesystem permission is missing for that?
You could try to add this to photos info.xml
https://github.com/nextcloud/maps/blob/master/appinfo/info.xml#L56-L58

No, it needs to be added there iirc: https://github.com/nextcloud/photos/blob/master/src/services/DavRequest.js
That should works for tags/timeline :)
For albums, there is https://github.com/nextcloud/photos/blob/48a1dab129e3ef2e50a5c3be88d4cc2073e88c54/lib/Controller/AlbumsController.php#L107-L116

[jakobroehrl]

No, it needs to be added there iirc: https://github.com/nextcloud/photos/blob/master/src/services/DavRequest.js
That should works for tags/timeline :)
For albums, there is https://github.com/nextcloud/photos/blob/48a1dab129e3ef2e50a5c3be88d4cc2073e88c54/lib/Controller/AlbumsController.php#L107-L116

@skjnldsv How to do this exactly? What do I have to add above?

[skjnldsv]

You need to add the same properties as the webdav returns

[archont00]

Has this been released in NC21 or is it waiting for some further tests?

[rakekniven]

Not IIRC.

[skjnldsv]

Yes it's part of 21

[rakekniven]

In photos I cannot delete any item while viewing. My NC is at v21.0.2

[skjnldsv]

In photos I cannot delete any item while viewing. My NC is at v21.0.2

this is viewer, photos needs a fix yes

[archont00]

Ah, good point. NC 21 File/Viewer indeed has a "Delete" option in menu.

Yet, the DEL key does not work :-(

[szaimen]

This is tracked here: #897

[jakobroehrl]

No, it needs to be added there iirc: https://github.com/nextcloud/photos/blob/master/src/services/DavRequest.js

@skjnldsv How to define the permissions? What do I have to add exactly into props?
Searched for permission but found nothing.

[DiegoRenner]

I'm on Nextcloud Hub II (23.0.4). Should the delete button be available for me in the viewer? Just not sure if something in my settings is wrong or not.

[skjnldsv]

@skjnldsv How to define the permissions? What do I have to add exactly into props? Searched for permission but found nothing.

@jakobroehrl

viewer/src/services/FileInfo.js

Line 45 in 267fd25

<oc:permissions />

[jakobroehrl]

This implementation was never finished.

[Sofahamster]

What's the status of this PR? It says merged, but I can't find a way to delete photos from within the gallery in NC 24.

[szaimen]

The feature is available within the files app.

[szaimen]

It will be available in the photos app with NC25, IIRC

[rakekniven]

What's the status of this PR? It says merged, but I can't find a way to delete photos from within the gallery in NC 24.

You made the same mistake like me: The viewer component is used in Files App to view images. This is not related to the viewer component in photos app and therefor no delete button for us. That was my understanding.

[skjnldsv]

This is not related to the viewer component in photos app and therefor no delete button for us

On Photos we have it now

[rakekniven]

On Photos we have it now

NC25 only?