Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore main_menu to its original place #1352

Merged
merged 3 commits into from Aug 10, 2020
Merged

restore main_menu to its original place #1352

merged 3 commits into from Aug 10, 2020

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Aug 10, 2020

else you won't be able to start the main_menu on certain installations

I've just encountered this as I wanted to acces the main_menu.

else you won't be able to start the main_menu on certain installations

I've just encountered this as I wanted to acces the main_menu.
@enoch85
Copy link
Member

enoch85 commented Aug 10, 2020

else you won't be able to start the main_menu on certain installations

Well, main_menu.sh is never used - we only run menu.sh right? I mean menu.sh get's the latest script...

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 10, 2020

else you won't be able to start the main_menu on certain installations

Well, main_menu.sh is never used - we only run menu.sh right? I mean menu.sh get's the latest script...

Yes, but all installations have an already downloaded menu.sh. So if you execute the local file it tries to download the hardcoded /static/main_menu.sh. That is the reason why it fails on my installation...

@enoch85
Copy link
Member

enoch85 commented Aug 10, 2020

In each update the latest script is downloaded. Since the last thing that happens in the setup is updating, everyone using the old VM will get the latest script, and everyone running the update script will also get the latest version.

https://github.com/nextcloud/vm/blob/master/nextcloud_update.sh#L84

@szaimen
Copy link
Collaborator Author

szaimen commented Aug 10, 2020

In each update the latest script is downloaded. Since the last thing that happens in the setup is updating, everyone using the old VM will get the latest script, and everyone running the update script will also get the latest version.

https://github.com/nextcloud/vm/blob/master/nextcloud_update.sh#L84

Ah okay but not if you have a running VM and try to access the main_menu without running the update.sh first...

@enoch85
Copy link
Member

enoch85 commented Aug 10, 2020

OK, we can merge this - keep it for some versions, and then remove it when we do the other cleanup of leftover scripts for backwards compatibility. Fine with me.

@enoch85 enoch85 merged commit 2c5cf8c into master Aug 10, 2020
@enoch85 enoch85 deleted the restore-main_menu branch August 10, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants