Bitwarden mailconfig

[szaimen]

No description provided.

[szaimen]

Some comments:

• What does adminSettings__admins= do? it gives admin acces to specified emailaddresses - should be configurable
• is it really enough to just restart bitwarden after writing those information to the file? yes!
• Those need to get configured:

globalSettings__mail__smtp__host=REPLACE
globalSettings__mail__smtp__port=587
globalSettings__mail__smtp__ssl=false
globalSettings__mail__smtp__username=REPLACE
globalSettings__mail__smtp__password=REPLACE

• maybe additionally:

you could make it a simple yes/no question while recommending to not disable ssl trust verification. or just leave a note that the option exists.
by default, that line does not exist in the global.override.env file, so you could insert it with "false" as well, so that one wouldn't have to look it up in the bitwarden documentation first.

[szaimen]

I haven't tested this but it should already work.

[enoch85]

Generally looks promising! Thank you!

[szaimen]

Since there is obviously an additional setting for starttls:
globalSettings__mail__smtp__startTls=true
bitwarden/server#451 (comment)
I would suggest to add this...

[enoch85]

I would suggest to add this...

Set it as default, and make it possible for the user to change port if wanted.

[szaimen]

I would suggest to add this...

Set it as default, and make it possible for the user to change port if wanted.

Already done by the latest commit 👍

[enoch85]

Are we ready to merge this?

[enoch85]

The text needs to be looked at, but I'm too tired now.

Code wise - looks good
Menu wise - looks good
Grammar - needs to be looked at

Thanks @szaimen! 🥇

[enoch85]

Actually, a rebuild is not needed based on @mamama1's experience.

Done.

Haven't tested, but it looks good.

Would you say we can merge? Have you tested?

[szaimen]

I've tested it on a test-VM with non-working bitwarden, so cannot say for sure, that everything works.
But at least the input and write process works. 👍