Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system-restore.sh and backup-viewer.sh #2426

Merged
merged 3 commits into from Jan 16, 2023
Merged

Conversation

pq2
Copy link
Contributor

@pq2 pq2 commented Jan 16, 2023

Compare https://github.com/nextcloud/vm/blob/master/not-supported/daily-backup-wizard.sh#L437

Fixed issue with inconsistent quotes related to ENCRYPTION_KEY
sed did not replace the normal ticks, which caused it to be considered part of the password, which is why during restoration it reported that the password was incorrect.

Signed-off-by: Florian Helmschmidt github@nhelmschmidt.de

Fixed issue with inconsistent quotes related to ENCRYPTION_KEY
Compare https://github.com/nextcloud/vm/blob/master/not-supported/daily-backup-wizard.sh#L437

Signed-off-by: Florian Helmschmidt <github@nhelmschmidt.de>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a small suggestion

not-supported/system-restore.sh Outdated Show resolved Hide resolved
Signed-off-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen changed the title Update system-restore.sh Update system-restore.sh and backup-viewer.sh Jan 16, 2023
@enoch85
Copy link
Member

enoch85 commented Jan 16, 2023

@pq2 Thanks! 👍🏼

@szaimen Do you approve?

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, forgot that I can :D

@enoch85 enoch85 merged commit 3b4cf72 into nextcloud:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants