SSL configuration creation #31
Conversation
Check if file exists after domain definition
Now test-new-config.sh should be able to enable the correct site
Now the test enable the configuration file created in activate-ssl.sh
|
@ezraholm50 Please test this, doesn't seem right at first look. Thanks! @Pe46dro Thanks for your PR!! |
| @@ -242,7 +245,7 @@ fi | |||
| # Check if $certfiles exists | |||
| if [ -d "$certfiles" ]; then | |||
| # Activate new config | |||
| bash /var/scripts/test-new-config.sh | |||
| bash /var/scripts/test-new-config.sh $domain.conf | |||
There was a problem hiding this comment.
Have you actually tested this?
There was a problem hiding this comment.
Proof of work: http://imgur.com/a/sDALF
I made two gist with the script so you can test it.
https://gist.github.com/Pe46dro/a6e26ce6c3bc6d0a70ff8053d80b5a3c
https://gist.github.com/Pe46dro/c9c1e84c1778f733d54d5954bb7cdd81
There was a problem hiding this comment.
test-new-config.sh is a totally different script that tests the configuration and has nothing to do with the domain name. @Pe46dro Please explain this fix.
|
I just checked this a little but more and understands the fix, not tested though. Lets's merge this anyway and see what response we get from other users. 👍 From me. |
|
Essentially before my change when you run the |
PR as requested #28
Now the file generation will be made after domain variable definition and configuration will be tested with the correct name
Sorry for multiple commits but i made it from Github Web