Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for running server #83

Merged
merged 8 commits into from Jan 7, 2017
Merged

Check for running server #83

merged 8 commits into from Jan 7, 2017

Conversation

Ark74
Copy link
Collaborator

@Ark74 Ark74 commented Jan 6, 2017

Checking for a running server and some cleaning.

Check for nextcloud server and some cleaning
Check for nextcloud server and some cleaning
Removed nextant:index
@Ark74
Copy link
Collaborator Author

Ark74 commented Jan 7, 2017

If we use the releases from github,
NT_RELEASE=nextant-master-$NEXTANT_VERSION.tar.gz

Could someone clarify me if, is it or isn't necessary to compile app?
https://github.com/nextcloud/nextant/wiki#installing-nextant

@Ark74 Ark74 requested a review from enoch85 January 7, 2017 05:19
@WaaromZoMoeilijk
Copy link
Member

WaaromZoMoeilijk commented Jan 7, 2017 via email

@Ark74
Copy link
Collaborator Author

Ark74 commented Jan 7, 2017

Ok, thanks.
Then i think the script is getting to a very good state. 👍

if [ $? -eq 0 ]
then
echo "Nextant app is now installed and enabled."
echo "Please go to: Admin Settings --> Additional Settings, and configure the app"
echo -e "Finally run \033[0;32msudo -u www-data php /var/www/nextant/occ nextant:index \033[0mto get nextant running."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just do this directly in the script?

Copy link
Collaborator Author

@Ark74 Ark74 Jan 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not until the settings on the nextant app are saved on the admin settings.
Maybe there is a "cli" way of saving them, not sure about it.
But before that it can't be done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user can do that directly in the app settings (at the bottom) so it's necessary to instruct the user to go to admin settings the back to CLI when both can be done in app settings.

@enoch85
Copy link
Member

enoch85 commented Jan 7, 2017

@ezraholm50 Can you review the changes please?

@enoch85
Copy link
Member

enoch85 commented Jan 7, 2017

Ok, tested and works!

@enoch85 enoch85 merged commit 2018432 into master Jan 7, 2017
@enoch85 enoch85 deleted the Ark74-patch-1 branch January 7, 2017 14:10
@WaaromZoMoeilijk
Copy link
Member

Works nicely!
https://hastebin.com/uhucijopif.scala

WaaromZoMoeilijk pushed a commit that referenced this pull request Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants