Add complete translation of PHP code and more forecast data #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: e-alfred
nerzhul
reviewed
May 8, 2019
|
I added support for more forecast data (every 3 hours for 5 days = 40 items) to max out the possible amount of data from the Openweathermap API:
|
e-alfred
changed the title
nerzhul
approved these changes
May 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second PR that completes the translation of the Weather app. It add a check for the current language set by the user and requests a translated dataset from the Openweathermap API. Additionally, it also translates the wind directions.
Together with #72 this should solve #60 completely.