Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multilingual support (#32) #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joho1968
Copy link

Multilingual support (#32)

The widget supports different languages by appending _lang to the specified filename. So if the original filename is mywelcome.md, the widget will look for mywelcome_sv.md for a user with Swedish set as their language. If that file is not present, the configured filename will be used.

(If the user has no specific language setting, the default language of the Nextcloud instance will be used.)

@joho1968
Copy link
Author

(not sure what happened with my gpg keys, but ... )

@joho1968
Copy link
Author

joho1968 commented Apr 3, 2023

Any chance of this being merged sometime soon?

@kyteinsky
Copy link
Contributor

Hi! Sorry, it took a bit long to get back to you.

There are two more things you would need to do here:

  1. Rebase this branch with the main branch
  2. Indent the code according to the existing style (tabs) and make it homogenous throughout the file

Thank you for your work!

@yennor
Copy link

yennor commented Nov 8, 2023

would love to get that merged :-)

@kyteinsky
Copy link
Contributor

@yennor Me too! Unfortunately, we are a bit stretched out in terms of workforce so it would not be possible to work on it directly. If you can address the above issues in a separate PR, I would be more than happy to review it!

@joho1968
Copy link
Author

joho1968 commented Nov 9, 2023

There are two more things you would need to do here:
1. Rebase this branch with the main branch
2. Indent the code according to the existing style (tabs) and make it homogenous throughout the file

Thank you for your work!

I did update my fork just now, what else do I need to do to rebase it?

I'm sorry, but all my development environments use space characters instead of TABs. Feel free to copy/paste my changes and style them to your liking. The amount of added/changed code really isn't a big deal.

@kyteinsky
Copy link
Contributor

Hey @joho1968
You need to rebase your branch multilang upon the main branch of the nextcloud repo.
If you're using an IDE, it should auto detect the indentation (or have a feature for it). They can also be manually overridden to use tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants