fix(state): hard crash when user_id is None #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spifory
suggested changes
Mar 20, 2023
Co-authored-by: toolifelesstocode <toolifelesstocode@gmail.com>
spifory
approved these changes
Mar 21, 2023
EmreTech
changed the title
EmreTech
added
t: bug
EmreTech
changed the title
ooliver1
changed the title
Skelmis
reviewed
Mar 29, 2023
|
In the future I would recommend using a separate branch in your fork other than |
ooliver1
approved these changes
Apr 5, 2023
ooliver1
reviewed
Apr 5, 2023
alentoghostflame
approved these changes
Apr 5, 2023
ooliver1
added a commit
that referenced
this pull request
Apr 5, 2023
* Fix hard crash when user_id is None Reflect https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object * Change to literal key word Co-authored-by: toolifelesstocode <toolifelesstocode@gmail.com> * refactor(state): use data.get("user_id") for cheaner checks * fix(state): ignore if user is None in audit log entry --------- Co-authored-by: toolifelesstocode <toolifelesstocode@gmail.com> Co-authored-by: Oliver Wilkes <oliverwilkes2006@icloud.com>
|
After this there is a new error Traceback (most recent call last):
File "/myBot/bot.py", line 214, in <module>
bot.run(os.environ["TOKEN"])
File "/myBot/venv/lib/python3.8/site-packages/nextcord/client.py", line 871, in run
return future.result()
File "/myBot/venv/lib/python3.8/site-packages/nextcord/client.py", line 850, in runner
await self.start(*args, **kwargs)
File "/myBot/venv/lib/python3.8/site-packages/nextcord/client.py", line 814, in start
await self.connect(reconnect=reconnect)
File "/myBot/venv/lib/python3.8/site-packages/nextcord/shard.py", line 511, in connect
raise item.error
File "/myBot/venv/lib/python3.8/site-packages/nextcord/shard.py", line 152, in worker
await self.ws.poll_event()
File "/myBot/venv/lib/python3.8/site-packages/nextcord/gateway.py", line 603, in poll_event
await self.received_message(msg.data)
File "/myBot/venv/lib/python3.8/site-packages/nextcord/gateway.py", line 553, in received_message
func(data)
File "/myBot/venv/lib/python3.8/site-packages/nextcord/state.py", line 2318, in parse_guild_audit_log_entry_create
entry = AuditLogEntry(auto_moderation_rules={}, users=users, data=data, guild=guild)
File "/myBot/venv/lib/python3.8/site-packages/nextcord/audit_logs.py", line 457, in __init__
self._from_data(data)
File "/myBot/venv/lib/python3.8/site-packages/nextcord/audit_logs.py", line 519, in _from_data
channel_id = int(self.extra["channel_id"])
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType' |
EmreTech
removed
the
s: awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect https://discord.com/developers/docs/resources/audit-log#audit-log-entry-object
Summary
Fix issue like detailed in https://discord.com/channels/881118111967883295/1084474550345023638
Checklist
task pyrightand fixed the relevant issues.