-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(guild): add bulk_ban
function
#1172
base: master
Are you sure you want to change the base?
Conversation
Ctrl + S must've formatted the whole file, this is irrelevant to what I'm adding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
If all users "failed" you get an error response instead
but i feel like this is a bit too unexpected, should go under a Raises: HTTPException: ...
(?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good otherwise!
Related Discord Docs PR was merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add versionadded 3.0 too since this should ideally be in for that.
Summary
Implements discord/discord-api-docs#6720 by adding a
bulk_ban
function toGuild
This is a Code Change
task pyright
and fixed the relevant issues.