feat!: async cache and object rewrite #1185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Schoenhofen <alexanderschoenhofen@gmail.com>
Skelmis
reviewed
May 21, 2024
EmreTech
changed the title
spifory
suggested changes
May 21, 2024
nextcord/message.py
Outdated
|
|
||
| def __repr__(self) -> str: | ||
| name = self.__class__.__name__ | ||
| return f"<{name} id={self.id} channel_id={self.channel_id} type={self.type}>" |
There was a problem hiding this comment.
Suggested change
| return f"<{name} id={self.id} channel_id={self.channel_id} type={self.type}>" | |
| return f"<{name} id={self.id!r} channel_id={self.channel_id!r} type={self.type!r}>" |
Comment on lines
+551
to
+554
| if inspect.iscoroutinefunction(func): | ||
| await func(data) | ||
| else: | ||
| func(data) |
There was a problem hiding this comment.
isn't this just utils.maybe_coro?
Signed-off-by: Alex Schoenhofen <alexanderschoenhofen@gmail.com>
alentoghostflame
force-pushed
the
guildless_recache
branch
from
4b5907c
to
7fde7e2
Compare
EmreTech
reviewed
May 22, 2024
| return self._members.pop((member_id, guild_id)) is not None | ||
|
|
||
| async def get_member(self, member_id: int, guild_id: int) -> Optional[MemberData]: | ||
| return self._members.get((member_id, guild_id), None) |
There was a problem hiding this comment.
Usually None is the default for dict.get.
Signed-off-by: Alex Schoenhofen <alexanderschoenhofen@gmail.com>
alentoghostflame
force-pushed
the
guildless_recache
branch
from
a4bd804
to
a0058aa
Compare
Signed-off-by: Alex Schoenhofen <alexanderschoenhofen@gmail.com>
alentoghostflame
force-pushed
the
guildless_recache
branch
from
b92425e
to
b6c1af7
Compare
Signed-off-by: Alex Schoenhofen <alexanderschoenhofen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to
To say this is in progress is an understatement. It will likely be quite a while before anything here is relatively usable, let alone useful. This is being published so people can monitor this and raise issues about the architecture before I dive too far into the wrong direction.
This is a Code Change
task pyrightand fixed the relevant issues.