Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactions): resolve ephemeral channels from cache #681

Merged
merged 3 commits into from Jun 16, 2022

Conversation

ooliver1
Copy link
Member

Summary

fixes #12
get the channel from cache if it exists, else assume it is a DM like before
guild is used if it is found in the channel

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for nextcord-gh-action ready!

Name Link
🔨 Latest commit c909e66
🔍 Latest deploy log https://app.netlify.com/sites/nextcord-gh-action/deploys/62a9d9bbcf5b770008d688e3
😎 Deploy Preview https://deploy-preview-681--nextcord-gh-action.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ooliver1 ooliver1 added t: bug Type: bug - something isn't working p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews labels Jun 15, 2022
nextcord/state.py Outdated Show resolved Hide resolved
@ooliver1 ooliver1 merged commit 4a4d266 into master Jun 16, 2022
@ooliver1 ooliver1 deleted the ooliver1/fix/resolve-ephemeral-channels branch July 8, 2022 06:19
@ooliver1 ooliver1 removed the s: awaiting review Status: the issue or PR is awaiting reviews label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: medium Priority: medium - should be worked on in the near future t: bug Type: bug - something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message.channel is a DMChannel in on_message for an ephemeral message not sent as a DM
3 participants