Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): add missing MessageFlags values #990

Merged
merged 5 commits into from Jun 14, 2023
Merged

feat(flags): add missing MessageFlags values #990

merged 5 commits into from Jun 14, 2023

Conversation

ooliver1
Copy link
Member

@ooliver1 ooliver1 commented Feb 8, 2023

Summary

The suppress notifications option is from discord/discord-api-docs#5910.
Bitshifted values seemed to have been missed in #911 as this is a flag

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have run task pyright and fixed the relevant issues.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@ooliver1 ooliver1 added p: high Priority: high - should be worked on as soon as reasonable s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API labels Feb 8, 2023
MaskDuck
MaskDuck suggested changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@MaskDuck MaskDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing the ability to set the flag in abc.Messageable.send.

@ooliver1
Copy link
Member Author

Is that not what #979 is?

spifory
spifory approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@spifory spifory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to add it to 2.4 or 2.5. Everything else looks good to me

Skelmis
Skelmis requested changes Apr 9, 2023
View reviewed changes
nextcord/flags.py Outdated Show resolved Hide resolved
nextcord/flags.py Outdated Show resolved Hide resolved
nextcord/flags.py Outdated Show resolved Hide resolved
@ooliver1 ooliver1 added the 2.5 The issue/PR should go for the 2.5 release label Apr 12, 2023
@ooliver1 ooliver1 added this to the 2.5 milestone Apr 12, 2023
@ooliver1 ooliver1 removed this from the 2.5 milestone Jun 13, 2023
@ooliver1 ooliver1 added 2.6 The issue/PR should go for the 2.6 release and removed 2.5 The issue/PR should go for the 2.5 release labels Jun 13, 2023
@ooliver1 ooliver1 added this to the 2.6 milestone Jun 13, 2023
@EmreTech EmreTech merged commit b3b249e into master Jun 14, 2023
9 checks passed
@EmreTech EmreTech deleted the ooliver1/feat/missing-message-flags branch June 14, 2023 21:52
@ooliver1 ooliver1 removed the s: awaiting review Status: the issue or PR is awaiting reviews label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskDuck MaskDuck MaskDuck requested changes

@Skelmis Skelmis Skelmis approved these changes

@EmreTech EmreTech EmreTech approved these changes

@spifory spifory spifory approved these changes

Assignees
No one assigned
Labels
2.6 The issue/PR should go for the 2.6 release p: high Priority: high - should be worked on as soon as reasonable t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
No open projects
Nextcord progress
Status: Done
Milestone
2.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ooliver1 @Skelmis @EmreTech @MaskDuck @spifory