Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to cargo zigbuild for Linux releases #1055

Closed
sunshowers opened this issue Oct 23, 2023 · 2 comments
Closed

Switch to cargo zigbuild for Linux releases #1055

sunshowers opened this issue Oct 23, 2023 · 2 comments

Comments

@sunshowers
Copy link
Member

We've been resorting to increasingly convoluted workarounds to get nextest compiling against glibc 2.27. So far we have:

The list of hacks is only going to grow, but we are ultimately limited by the fact that we need to support at least glibc 2.28 (minimum of versions supported across CentOS, Debian, and Ubuntu LTS).

It seems like cargo zigbuild might be able to solve our problems here by letting us build against glibc 2.27 (or 2.28?), and I did a basic check (strings target/release/cargo-nextest | grep GLIBC) to ensure it works. Some notes:

ccing @NobodyXu in case you have thoughts.

@NobodyXu
Copy link
Contributor

We use cargo-zigbuild with cargo-auditable and cargo-hack (<=0.6.10, newer version use new cargo subcommand which cargo-zigbuild doesn't support forwarding yet rust-cross/cargo-zigbuild#195) by setting env CARGO

https://github.com/cargo-bins/cargo-binstall/blob/dc20cb7eb37d0bc4b498ade18a4e78a52358c6ad/justfile#L46

@sunshowers
Copy link
Member Author

Fixed in commits leading up to d80d85f. Verified that this worked in an Ubuntu 18.04 container:

root@5ab2a8b65fd0:/# curl -fsSL https://github.com/nextest-rs/nextest/releases/download/cargo-nextest-0.9.62-a.2/cargo-nextest-0.9.62-a.2-x86_64-unknown-linux-gnu.tar.gz | tar zx
root@5ab2a8b65fd0:/# ./cargo-nextest

sunshowers added a commit to guppy-rs/guppy that referenced this issue Feb 4, 2024
The ubuntu:18.04 container no longer works. See
nextest-rs/nextest#1055.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants