Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to parse benchmark #46

Closed
BusyJay opened this issue Feb 15, 2022 · 1 comment · Fixed by #48
Closed

unable to parse benchmark #46

BusyJay opened this issue Feb 15, 2022 · 1 comment · Fixed by #48
Assignees
Labels
bug Something isn't working

Comments

@BusyJay
Copy link

BusyJay commented Feb 15, 2022

Any functions marked as benchmark by #[bench] using rust builtin bench will fail to be parsed.

   0: error building test list
   1: line 'byte::benches::bench_memcmp_decode_first_asc_large: benchmark' did not end with the string ': test'

If they are not supported on purpose, then ignore them may be a better alternative.

@sunshowers sunshowers self-assigned this Feb 15, 2022
@sunshowers sunshowers added the bug Something isn't working label Feb 15, 2022
@sunshowers
Copy link
Member

Yeah, I agree that lines ending with ": benchmark" should be ignored. I'll try to do a fix for this today.

sunshowers added a commit to sunshowers/nextest that referenced this issue Feb 15, 2022
These lines are produced by the default Rust benchmark harness.

Fixes nextest-rs#46.
sunshowers added a commit that referenced this issue Feb 15, 2022
These lines are produced by the default Rust benchmark harness.

Fixes #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants